Fail run_check and run_pipe on non-zero exit#28
Merged
Conversation
The shared test helpers captured the subprocess exit code into rc but never consulted it. A guest that printed the expected substring and then died on SIGBUS or SIGSEGV (rc 138 or 139) would still match the pattern via grep and report OK, hiding the crash. Check rc first in both helpers: any non-zero exit is reported as FAIL with the exit code in the detail, before the pattern match runs. The remaining branches keep the original semantics for the clean-exit cases. All current callers in test-busybox.sh and test-coreutils-smoke.sh expect rc 0 from the applet under test; non-zero-rc cases use the explicit run helper, which is unchanged.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
|
Thank @Max042004 for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared test helpers captured the subprocess exit code into rc but never consulted it. A guest that printed the expected substring and then died on SIGBUS or SIGSEGV (rc 138 or 139) would still match the pattern via grep and report OK, hiding the crash.
Check rc first in both helpers: any non-zero exit is reported as FAIL with the exit code in the detail, before the pattern match runs. The remaining branches keep the original semantics for the clean-exit cases.
All current callers in test-busybox.sh and test-coreutils-smoke.sh expect rc 0 from the applet under test; non-zero-rc cases use the explicit run helper, which is unchanged.
Summary by cubic
Make
run_checkandrun_pipefail on any non-zero exit before pattern matching, so crashes don’t get reported as passing.rcfirst; non-zero exits now report FAIL withrcand output excerpt.runhelper is unchanged.Written for commit aded850. Summary will update on new commits.